Conversation
Update ldk-server-client to the revision containing support for features on GraphNodeAnnouncement. This enables SimLN to replace its hardcoded keysend assumption with the features advertised by remote nodes.
Populate remote node features from GraphNodeAnnouncement instead of assuming every graph node supports keysend. Treat missing announcements as having no advertised features and add tests covering keysend, multiple feature bits, and missing announcements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
LdkServerNodeassumed every remote graph node supportskeysendbecause LDK Server node announcement features were not previously exposed by its API. This allowed nodes that do not advertisekeysendsupport to pass activity validation, resulting in avoidable payment failures.Here we:
ldk-server-clientrevision to include graph node announcement features.keysendsupport. Nodes without announcement information are treated as having no advertised features.Closes #310