limit max_total_cltv_expiry_delta for pathfinding - #318
Merged
Merged
Conversation
Previously we were ignoring the 2016 limit for cltv delta so we could end up building a route for more than 2016 which any node should reject. This will now use LDK's default of 1008.
carlaKC
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running a simulation using channel policies from mainnet graph and found out some set the
cltv_expiry_deltato 2016...For some reason, we had set to
.with_max_total_cltv_expiry_delta(u32::MAX)meaning that it will build routes with any delta. It ended up building a route where it ended up > 2016 blocks which is above the protocol recommended value to fail a HTLC. This caused some shutdowns in the simulation I was running. This will now use the LDK default of 1008.