Repository navigation
Conversation
decode() used Number(), so amount=0x10 became 16. Require a decimal string before converting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decode()convertedamountwithNumber().amount=0x10became16. BIP21 amounts are decimal BTC. A decimal string is required before the conversion.0,1.00,20.3, and0.200000still decode.Test plan
decode("bitcoin:addr?amount=0x10").options.amountwas16amount=0x10throwsInvalid amountnpx tape test/*.js(55 tests OK)Made with Cursor