Repository navigation
Feature/573 add catalog.rounding rule v3 - #581
Merged
mesilov merged 3 commits intoSep 28, 2026
Merged
Conversation
mesilov
added a commit
that referenced
this pull request
Sep 28, 2026
`make lint-rector` and `make test-unit` were both red on v3-dev after #581. * phpunit.xml.dist: close missing `</testsuite>` for `integration_tests_catalog_rounding_rule` — malformed XML aborted the whole PHPUnit run (same defect shape as the ratio suite in #574) * CatalogServiceBuilder: fix indentation of `roundingRule()` and trailing blank lines (braces_position, statement_indentation, no_whitespace_in_blank_line) * rector.php: revert the set/skip change from 7a80e3d. Both premises do not hold for the installed Rector 2.5.2: `PHPUnitSetList::PHPUNIT_110` is still declared, and `DeprecatedAnnotationToDeprecatedAttributeRector` is still registered — un-skipping it made `lint-rector` demand rewriting `@deprecated` docblocks into `#[\Deprecated]` attributes in 6 files, which is a runtime-behaviour change (the attribute emits E_USER_DEPRECATED), not a no-op cleanup * CHANGELOG: drop the two `3.5.0 / Fixed` entries describing that reverted change, and move the `RoundingRule` entry (#573) out of the already-tagged 3.5.0 section into 3.6.0 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for catalog.roundingRule.*
https://apidocs.bitrix24.com/api-reference/catalog/rounding-rule/index.html
catalog.roundingRule.add
catalog.roundingRule.update
catalog.roundingRule.get
catalog.roundingRule.list
catalog.roundingRule.delete
catalog.roundingRule.getFields
Fixed
make lint-rectorfailing withUndefined constant Rector\PHPUnit\Set\PHPUnitSetList::PHPUNIT_110:the versioned PHPUnit set constants (
PHPUNIT_60,PHPUNIT_90,PHPUNIT_110, etc.) were removedfrom
rector/rector-phpunitin the installed Rector version and replaced with consolidated sets(
PHPUNIT_CODE_QUALITY,PHPUNIT_MOCK_TO_STUB,PHPUNIT_NARROW_ASSERTS,ANNOTATIONS_TO_ATTRIBUTES).Compared the dry-run impact of each candidate:
PHPUNIT_CODE_QUALITYwould touch 477 files,PHPUNIT_NARROW_ASSERTS91 files — both unrelated repository-wide style changes out of scope here.ANNOTATIONS_TO_ATTRIBUTES(migrates legacy@annotationdocblocks to PHP 8 attributes, the closestmatch to what
PHPUNIT_110used to cover) touches 0 files, since the codebase already uses PHP 8attributes everywhere; replaced the obsolete
PHPUnitSetList::PHPUNIT_110reference inrector.phpwith
PHPUnitSetList::ANNOTATIONS_TO_ATTRIBUTESRemoved the obsolete
Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRectorentry from
rector.php→withSkip(): the rule is deprecated and no longer registered in theinstalled Rector version, so
make lint-rectorreported it as a dead skip entry