Integrate milestone 1.13.0 with conflict and compatibility fixes - #635
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates milestone 1.13.0 PRs #602, #607, #610, #613 and #618 into
dev, preserving their commits and authorship. Resolves conflicts in the changelog, Catalog service builder, Make targets and PHPUnit suites while retaining all 1.12.0 changes.The combined review also fixes two runtime regressions: 40 existing Booking/Catalog/Sale constructors retain both positional and named-argument compatibility, with optional batch injection as the third argument; userfield configuration enum rows now return typed result objects with boolean default flags. A narrowly scoped Rector exception preserves the six inherited
$logparameter names.Validation:
make test-unit(878 tests, 2204 assertions),make lint-all(licenses, PHP-CS-Fixer, PHPStan, Rector), andgit diff --check. Regression tests reproduced the constructor and enum failures before the fixes. Live Bitrix24 portal integration tests were not run.