Repository navigation
Simplify gates; fix focus, dark figures, footer, print; replace ar5iv figures - #90
Merged
Merged
Conversation
- lint-posts.rb: one code-span helper; drop rules that never fired (tag case, cross-line span state) and the ENV["TZ"] side effect; use_math folded into the body pass; date-only values; reject ar5iv links. - check-plugin-output.rb takes the translation-listing check (twins from front matter) and checks every page for a repeated id; validate-site.sh drops checks that could not fail or duplicated the lint. - UI: focus ring on zoomable figures, white backdrop for transparent figures in dark mode, section highlighted on posts, lightbox returns focus, footer at the bottom and aligned, 44px menu button, print styles. - head.html: drop the always-true fb_image guard; site.author replaces the duplicate name key. CI passes the Pages base path through env. - README and tech-doc: shorter authoring guidance, fixes to stale text.
ar5iv serves a NO IMAGE AVAILABLE PNG with HTTP 200 for figures it lost. 46 figures move to arxiv.org/html; 42 from papers without an HTML version are rendered from the arXiv sources into assets/images. The Llama 2 post drops three images standing in for tables, and three figures move to or gain the caption the text describes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial review loop (code/architecture, tests/CI/docs, UI/UX/visuals), 3 rounds; round 3: 0 MAJOR in both reviews.
Fixed on the live site
assets/images/<slug>-arxiv-xN.pngand checked against their captions. Two ar5iv citation links in QLoRA point at the Elo rating article instead.Gates (
post_conventions.ymlunchanged)script/lint-posts.rb: removed rules that never fired in any of 113 historical_posts/snapshots and are unlikely under the workflow (tag case across posts, cross-line inline-span state); oneCODE_SPAN/strip_codehelper;use_mathfolded into the body pass; noENV["TZ"]side effect; date-only values compared as dates. New rule: ar5iv links — fails, passes.script/check-plugin-output.rbnow also: translation-listing check (twins from front matter, so a disabled hook cannot hide them), and one id per page (a tag spelled two ways gives two tag sections with one id; replaces the lint's tag-case rule).script/validate-site.sh: dropped the redirect-target check (stubs always targetpost.url, which the plugin check verifies) and the feed author grep (the lint forbidsauthor:).env:.Cleanup
head.html: always-truefb_imageguard removed;site.authorreplaces the duplicatenamekey. README authoring section trimmed to the rules authors trip on; tech-doc's rule enumeration replaced by a pointer to the script and tests.Gates: tests (169), post lint, strict build, htmlproofer (CI flags), validate-site, shellcheck, actionlint; axe-core 0 violations; MathJax 0 errors.