Repository navigation
Fix lightbox and its links, tidy gates; refresh about portrait - #91
Merged
Merged
Conversation
- Lightbox: white backdrop for transparent figures, an accessible focus ring on a black band, unpadded black buttons with disabled arrows still dimmed, a dark caption band on phones, focus on close when it opens, a Tab trap that skips off-screen arrows (also on resize), focus back to the figure on close (the handler was never registered: .on() does not chain), aria-modal and a label. - lint-posts.rb: a hand-written glightbox link must open its own image; skip what Jekyll skips (special and backup files); shared slug helper. - validate-site.sh: Disallow check kept, claims narrowed; <title> escaped; Copy buttons hidden in print; tests for untested branches; the comment test now fails when the comment pass is removed.
… figures - AI-ready-data (ko, en): 16 lightbox links pointed at source pages the lightbox could not frame; they now open their own images. - Gemma 3: the memorization figure, clipped at its title, re-rendered from the arXiv source. - About: the portrait redrawn on model with the omnisummary owner persona. - 50 figures no post references, under assets/<post>/, removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial review loop (code/tests/CI/docs and UI/UX/visuals), 5 rounds; round 5: 0 MAJOR in both reviews.
Fixed on the live site
<button>padding (close icon was 18×5 px) and stay opaque while disabled arrows keep their dimming; phone captions on a dark band (1.5:1 over white figures); focus moves to close on open, the Tab trap skips arrows that are off-screen below 769 px (also on a live resize), focus returns to the figure on close — that handler had never been registered because GLightbox's.on()does not chain;aria-modaland a label.<title>is escaped.Gates
<a class="glightbox">must link its own image. Fails<a href="https://arxiv.org/abs/1" class="glightbox"><img src="/assets/images/a.png"></a>; passes whenhrefequalssrc. Handles either quote style, extra classes,>inside attributes, and skips fenced code.EntryFilter#special?and#backup?), e.g. a stray_posts/_site/.validate-site.sh: the robotsDisallow: /check stays; claims about what each check guards narrowed.\mathrm, SVGpx, strikethrough, lightbox line numbers). 172 runs.Cleanup
50 figures under
assets/<post>/that no post references (Tulu 3, Llama 3, Gemini, Gemini 2.5), about 3 MB.post_conventions.ymlunchanged.Gates: tests, post lint, strict build, htmlproofer (CI flags), validate-site, shellcheck, actionlint; axe-core 0 violations; every lightbox on every post opens its image.