Repository navigation
Fix mobile lightbox, print, code blocks; JPEG for two photos - #95
Merged
Merged
Conversation
- Mobile lightbox: caption below the figure, centred with it, clear of the close button. - Print: code wraps, wide tables and display math shrink, no cover band, no copy-button strip. - Code: opaque copy button above the code; no per-line bands in dark mode; a bare <pre><code> (cedar) gets the same panel; 0.9em no longer compounds to 0.81em. - validate-site.sh counts characters, not bytes, in any locale. - Tests that could not fail now can; tests for untested lint branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adversarial review loop (code/tests/CI/docs and UI/UX/visuals), 4 rounds; round 4: 0 MAJOR in both reviews.
Fixed on the live site
Gates and tests
validate-site.shcompares description and title length in characters in any locale (it counted bytes underLC_ALL=C), without spawning a process per page.Assets
Two photographic Gemini figures as JPEG (2.6 MB → 552 KB, 2.0 MB → 272 KB).
post_conventions.ymlunchanged.Gates: tests (173), post lint, strict build, htmlproofer (CI flags), validate-site (also under
LC_ALL=C), shellcheck, actionlint; axe-core 0 violations.