Repository navigation
Robustness to new content: nav height, TOC numbering, quoted fences, seo_title - #99
Merged
Merged
Conversation
An eighth tab wrapped the bar to two rows at 960px and up, and the fixed bar covered each page's heading; the offset was a fixed 66px. main.js now passes the bar's height as --nav-height. Also: the main landmark's id is main-content, so a '## Content' heading cannot collide with it; the lint allows q, time, var, samp, u, dfn, track and the SVG marker and ellipse; the categories description no longer lists the types.
…phone menu The Insights posts number their h2s, so the TOC read '2 1. …'. Held sideways, a phone is shorter than the open menu, whose last items sat off-screen. Previous/next titles and home-page entries carry their own post's lang.
scholar-lens quotes prompts as '> ```' blocks; the lint read their <tag> lines as prose. The lightbox check skips such fences too.
With a two-row bar the page painted at 66px and then dropped (CLS 0.33); an inline script after the header sets --nav-height first. Browsers without ResizeObserver or MediaQueryList.addEventListener fall back instead of aborting main.js. seo_title now shortens any post's <title>, not only a paper's. The SVG child names stay as they were: allowed in prose, they would hide a <marker> placeholder.
…only when most headings carry them
…on a quoted marker A '> ```' line inside a bare ```markdown example ended the block early, and the lightbox check used a second, different fence pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from three adversarial review rounds (code/tests/docs and UI/UX), focused on overfitting to the current content. The final round found 0 MAJOR issues.
Overfitting and robustness
--nav-height. An inline script after the header sets it before first paint (CLS 0.33 → 0.006 with 8 tabs), andjs/main.jskeeps it in step, with fallbacks for browsers without ResizeObserver orMediaQueryList.addEventListener.seo_title: it applies to any post's<title>, not only paper posts. A long guide title from scholar-lens was ignored before.main-content, so a## Contentheading cannot collide with it.lang: previous/next titles and home entries carry their post'slang.New
script/lint-posts.rbbehaviour (for scholar-lens)> ```…) are code. The<tag>, colon and math rules no longer read them as prose. Liquid is still flagged there, because Jekyll renders it in code too.> ```text/> 답을 <think> 안에 쓰세요/ `> ````> 답을 <think> 안에 씁니다.q,time,var,samp,u,dfnandtrackare allowed in prose._data/post_conventions.ymlis unchanged. No post content is changed.Verification