Skip to content

PM-42849: Feat: Update Debug menu UI - #7338

Merged
david-livefront merged 1 commit into
mainfrom
PM-42849-debug-menu-update
Sep 1, 2026
Merged

PM-42849: Feat: Update Debug menu UI#7338
david-livefront merged 1 commit into
mainfrom
PM-42849-debug-menu-update

Conversation

@david-livefront

@david-livefront david-livefront commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-42849

📔 Objective

This PR updates the debug menu UI in order to better support the ever-growing list of feature we have.

📸 Screenshots

Before After
Screen_recording_20260831_155320.mp4
Screen_recording_20260831_155026.mp4

@david-livefront
david-livefront requested a review from a team as a code owner August 31, 2026 20:53
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Aug 31, 2026
@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR restructures the debug menu into FLAGS and OPTIONS tabs backed by a new MainTypeOption state, extracts screen callbacks into a DebugMenuHandler, and adds a shared segmentedContentTransform for the tab animation. The change is debug-menu only with no impact on vault data, crypto, or network paths; the BitwardenSegmentedButton default optionContent change matches the width/height modifiers GeneratorScreen already applies in its custom content, and the only other call site overrides that lambda. One test was moved to the wrong tab and will no longer find the node it clicks; the rest are state-shape updates that track the new mainTypeOption field.

Code Review Details
  • ⚠️ : reset feature flag values test switches to the OPTIONS tab, but the "Reset values" button renders only in the FLAGS tab
    • app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuScreenTest.kt:124
  • ♻️ : Handler KDoc references CheckEmailHandler, pulling in an unrelated cross-feature import
    • app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/handler/DebugMenuHandler.kt:34, :74, :6
  • ♻️ : MainTypeOption.testTag is declared but never passed to SegmentedButtonState
    • app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/debugmenu/DebugMenuViewModel.kt:170

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.04329% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.92%. Comparing base (4ecccfd) to head (2379cea).

Files with missing lines Patch % Lines
...form/feature/debugmenu/handler/DebugMenuHandler.kt 66.66% 18 Missing and 1 partial ⚠️
...n/ui/platform/feature/debugmenu/DebugMenuScreen.kt 97.51% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7338      +/-   ##
==========================================
- Coverage   86.16%   85.92%   -0.24%     
==========================================
  Files         928      901      -27     
  Lines       67315    66396     -919     
  Branches    10156    10153       -3     
==========================================
- Hits        58002    57051     -951     
- Misses       5735     5762      +27     
- Partials     3578     3583       +5     
Flag Coverage Δ
app-data 18.27% <0.00%> (+0.24%) ⬆️
app-ui-auth-tools 18.76% <0.00%> (-0.06%) ⬇️
app-ui-platform 16.31% <90.04%> (+0.12%) ⬆️
app-ui-vault 27.10% <0.00%> (-0.59%) ⬇️
authenticator 6.02% <0.00%> (-0.04%) ⬇️
lib-core-network-bridge 4.04% <0.00%> (-0.04%) ⬇️
lib-data-ui 1.18% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront
david-livefront force-pushed the PM-42849-debug-menu-update branch 5 times, most recently from f51d550 to a6c8cdc Compare August 31, 2026 21:16
@david-livefront
david-livefront force-pushed the PM-42849-debug-menu-update branch from a6c8cdc to 2379cea Compare August 31, 2026 21:55

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront
david-livefront added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 8152f5c Sep 1, 2026
26 checks passed
@david-livefront
david-livefront deleted the PM-42849-debug-menu-update branch September 1, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants