feat(saml): SimpleSaml local assertion encryption - #8319
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR is scoped entirely to local development tooling: a new Both findings from the earlier review round are resolved at head: the Aspire path now has a matching bind mount, and commit Code Review DetailsNo code findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8319 +/- ##
===========================================
+ Coverage 17.70% 63.89% +46.19%
===========================================
Files 1480 2471 +991
Lines 64163 105932 +41769
Branches 5148 9601 +4453
===========================================
+ Hits 11359 67684 +56325
+ Misses 52607 35907 -16700
- Partials 197 2341 +2144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Rely on manual copy procedure, outlined in contributing docs. Follows the same pattern as auth sources for the IdP.
| SIMPLESAMLPHP_SP_SINGLE_LOGOUT_SERVICE: null | ||
| volumes: | ||
| - ./authsources.php:/var/www/simplesamlphp/config/authsources.php | ||
| - ./saml20-sp-remote.php:/var/www/simplesamlphp/metadata/saml20-sp-remote.php |
There was a problem hiding this comment.
Interested in any feedback here.
Docker Compose can't bind to a conditionally-present file. If the file is not present, Compose will make a placeholder directory behind the scenes. This asks us to add another setup step for idp (copy the un-configured example, much like authsources.php) or accept behavior that can be hard to debug later.
We don't have a precedent for this today. I have an idea outlined here, but holding on a gut-check for that approach.
There was a problem hiding this comment.
I agree w/ this approach. Reasoning given bitwarden/contributing-docs#858 (comment)
Thank you for adding this new capability.
JaredSnider-Bitwarden
left a comment
There was a problem hiding this comment.
LGTM! Thank you
🎟️ Tracking
PM-43087
📔 Objective
saml20-sp-remote.phpfile for local configuration.Verified via docker compose and Aspire Apphost.