Repository navigation
fix(FormFieldCombobox, FormFieldMultiSelect): point the label at the trigger and pass the invalid state (#574) - #595
Merged
Conversation
…trigger and pass the invalid state (#574) Both wrappers rendered a BbFieldLabel with no for, so the label wasn't tied to the control, and kept their invalid state to themselves, so ErrorText never reached the trigger's aria-invalid. They now give the inner control's trigger the field's generated id, point the label's for at it, and pass IsInvalid down, the way BbFormFieldTreeSelect does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #587 (#574).
BbFormFieldCombobox and BbFormFieldMultiSelect rendered a label with no
for, so it wasn't tied to the control, and never passed their invalid state down, soErrorTextdidn't setaria-invalidon the trigger.Changes
TriggerIdand pointBbFieldLabel Forat it, matching BbFormFieldTreeSelect.IsInvalidto the inner control, soErrorTextand form validation errors both mark the trigger invalid.aria-invalidare tied to.Tests
FormFieldTriggerTests(8 tests): labelformatches the trigger button's id;aria-invalidandaria-describedbyfollowErrorText/HelperText; the trigger follows form validation that runs after render, both ways.ErrorTexttests fail on the old wrappers. The form-validation tests pass either way; they guard that passingIsInvaliddown doesn't stop the trigger following validation.BbFormFieldSelect has the same unlinked label; that's left for a separate change.