Repository navigation
fix(ColorPicker): presets label spacing and no-op space-y-2 wrappers (#598) - #603
Merged
Merged
Conversation
…ce-y-2 (#598) The presets label was an inline span, so the wrapper's space-y-2 margin never applied. Make it block-level. The hue and alpha slider wrappers have a single child, so space-y-2 did nothing there; remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #598.
<span>, so the wrapper'sbb:space-y-2margin never applied. Addedbb:blockso the label sits a small gap above the swatches.bb:space-y-2from the hue and alpha slider wrappers. Each has a single child, so the class had no effect.Kept to class changes only, so it rebases cleanly against #600, which edits the same label line.