Repository navigation
feat(Dialog): configurable position (#612) - #614
Merged
Merged
Conversation
Dialog takes a Position parameter (DialogPosition: Center, TopCenter, BottomCenter, CenterLeft, CenterRight, TopLeft, TopRight, BottomLeft, BottomRight). DialogService dialogs take the same value through DialogOpenOptions.Position. Center stays the default, so dialogs that don't set it are unchanged. Adds a demo section, code snippet and API Reference entries, and updates the API surface snapshot.
mathewtaylor
marked this pull request as ready for review
October 16, 2026 01:26
…n check DialogPosition names physical sides (CenterLeft, TopRight, ...), the same way ToastPosition does, so its placement classes stay physical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #612.
What changed
DialogPositionenum:Center,TopCenter,BottomCenter,CenterLeft,CenterRight,TopLeft,TopRight,BottomLeft,BottomRight.BbDialog.Positionparameter, cascaded toBbDialogContent.DialogOpenOptions.Position, used byBbDialogProviderforDialogService.OpenAsync<TComponent>()dialogs.Center. With no position set, a dialog gets the same classes as before.Notes
w-[calc(100%-2rem)]so they keep that gutter on narrow screens.auto. A native<dialog>opened withshowModal()getsinset: 0from the browser, and without this it would stay top-left.Docs
position.txtsnippet.Dialog.PositionandDialogOpenOptions.Position.Tests
DialogPositionTests(bUnit): default stays centred, and an explicit position applies, for bothBbDialogandDialogService.