Repository navigation
feat: backfill user_id on webhooks and forwarding_rules - #12
Merged
Merged
Conversation
Step 2 of the user-ownership plan. Copies sessions.user_id onto each webhook and forwarding rule whose session is signed in. Rows from anonymous sessions stay NULL, and a user_id that's already set is left alone. The UPDATEs run with the other migrations on every boot. They only match rows that still need a value, so after the first boot they change nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of blip-cloud's
docs/plans/user-owned-resources.md. #11 added auser_idcolumn towebhooksandforwarding_rules; this fills it from the owning session'ssessions.user_id.Two
UPDATEs go at the end ofMigrations.migrations. Each only matches rows withuser_id IS NULLwhose session has auser_id, so:NULL;user_idthat's already set isn't overwritten;Nothing reads the column yet, so this changes no behaviour. Steps 3 and 4 start writing and reading it.
MigrationsSqlTestgets two tests. One covers a signed-in and an anonymous session, each with a webhook and a rule; it failed before the change. The other checks that an existinguser_idis kept.