Repository navigation
Conversation
This cleanup removes packages from the previous OS in a special root context. Their erase scriptlets can fail or act on the wrong system, so skip them. Fixes: bootc-dev#2561 Signed-off-by: ckyrouac <ckyrouac@redhat.com>
6a42326 to
c9c5c24
Compare
This cleanup removes packages from the previous OS in a special root context. Their erase scriptlets can fail or act on the wrong system, so skip them. Fixes: bootc-dev#2559 Signed-off-by: ckyrouac <ckyrouac@redhat.com>
c9c5c24 to
22df875
Compare
|
re: my comment over in #2560 (comment) I think I was wrong about I think this is probably still the correct fix, though, regardless of the outcome of my investigation. |
|
Ok more added in #2559 (comment), I'm less certain about this approach now. This PR would probably be sufficient, but given the added context feels a bit hacky. |
|
I'm not a fan of skipping all scripts; it's a big hammer. Not saying it's wrong but a targeted fix feels better. |
|
The goal of the bootc-destructive-cleanup-script is to reduce disk space used by the old system without removing interesting configs/user defined state. Seems like it'd be best to ensure the RPMs are removed since that will most likely be the largest chunk of disk space to free. Although I'm not sure what is typically done in a post uninstall script, so maybe there is some significant space that would be freed that we would miss when using --noscripts. |
This cleanup removes packages from the previous OS in a special root context. Their erase scriptlets can fail or act on the wrong system, so skip them.
Fixes #2559