repository: raise PackNotFound when get_many hits a missing pack#9864
Open
mr-raj12 wants to merge 1 commit into
Open
repository: raise PackNotFound when get_many hits a missing pack#9864mr-raj12 wants to merge 1 commit into
mr-raj12 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9864 +/- ##
==========================================
+ Coverage 85.09% 85.12% +0.02%
==========================================
Files 93 93
Lines 15450 15458 +8
Branches 2335 2337 +2
==========================================
+ Hits 13147 13158 +11
+ Misses 1604 1599 -5
- Partials 699 701 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_many() now raises PackNotFound instead of ObjectNotFound when a chunk's index entry points at a pack that's missing from the store. That's a different failure than a single missing object: it usually means the index is stale, or we've lost more than one chunk's worth of data. follow up for review comment on #9836.
Added a test for it: delete a pack but leave its index entry, then check PackNotFound fires, and that raise_missing=False still just yields None.