fix(gui): accept an empty passphrase when opening a repository#182
Open
MaxenceG2M wants to merge 1 commit into
Open
fix(gui): accept an empty passphrase when opening a repository#182MaxenceG2M wants to merge 1 commit into
MaxenceG2M wants to merge 1 commit into
Conversation
The password dialog returns `Some(value)` on submit (including an empty
field) and `None` on cancel/close, so the two cases are already
distinguishable. `resolve_passphrase_tracked` was filtering the empty
string to `None`, collapsing "OK on an empty field" into the same state
as a dismissed prompt; downstream `with_passphrase_retry` then reported
the encrypted repo as `Canceled` and never opened it.
An empty passphrase is a legitimate, CLI-supported state (the CLI passes
whatever is typed straight through, so `vykar init` + Enter/Enter creates
such a repo). Let the empty string flow through as `Some("")`; only
`None` (dismissed) now means "no passphrase entered".
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The password dialog returns
Some(value)on submit (including an emptyfield) and
Noneon cancel/close, so the two cases are alreadydistinguishable.
resolve_passphrase_trackedwas filtering the emptystring to
None, collapsing "OK on an empty field" into the same stateas a dismissed prompt; downstream
with_passphrase_retrythen reportedthe encrypted repo as
Canceledand never opened it.An empty passphrase is a legitimate, CLI-supported state (the CLI passes
whatever is typed straight through, so
vykar init+ Enter/Enter createssuch a repo). Let the empty string flow through as
Some(""); onlyNone(dismissed) now means "no passphrase entered".Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com