Repository navigation
Test copy semantics, and versions, batch versions and restores - #13
Merged
Merged
Conversation
15 cases, verified live: an S3 REPLACE replaces content properties with metadata, and with none clears metadata or tags; UploadPartCopy reports a failed source condition as 412; Copy Blob ignores content properties, which Put Blob From URL honors; a From URL source that is missing is 404 CannotVerifyCopySource. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Batch deletes, ListObjectVersions and restore get new call and result fields, and blob_batch compares each subrequest's query. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review. CI passes, with the borink adapter pinned at object-storage a231d3b, which passes every case.
Summary
REPLACEreplaces the content properties with the metadata, so a copy naming only metadata getsbinary/octet-stream.REPLACEwith no metadata or no tags clears them. A client API that cannot say so may refuse or decline.PreconditionFailed.CannotVerifyCopySource.versionid. S3 answers a deleted version with 404NoSuchVersionand an ID it could never have given with 400InvalidArgument.delete_manykey may be{"key", "version"}, on Azure also{"key", "snapshot"}.blob_batchnow compares each subrequest's query.list_pagewithinclude: ["versions"]pages bycontinuation_tokenand a newversion_marker. A directory bucket answers 501NotImplemented, which a client may refuse.restorecall reportsstatestartedorreadable, and reads reportrestore_status.REFERENCE.mdhas the new result fields.?tagging=tagging,?restore=restoreand?versions=versionsbeside another parameter. S3 accepts that, so the cases do too.Test plan
object-tests validate cases/operations.jsonpasses (1,132 cases).cargo testpasses.