Repository navigation
Grade large bodies that no file holds, in a suite of their own. - #15
Merged
Merged
Conversation
A body can be a pattern repeated to a length, known by its length and CRC64NVME, and the grader streams and checks such bodies without keeping them. large.json holds 30 cases for the S3 and Azure size limits, the Azure From URL limits and a large ranged read, all verified live. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a large-body suite,
cases/large.json, and the grader support it needs. Large cases never enteroperations.json, so the other suites cost what they did. CI validateslarge.jsonbut does not grade it; a run of it is always asked for.Grader:
{"encoding": "repeat", "data": {"pattern_base64", "length"}}, in a response, a call'sbody, or the new rulegenerated_body.crc-fast). It keeps bytes only up to the existing 16 MiB.aws-chunkedrequest is decoded as it arrives, as S3 does. Its payload's fingerprint goes indecoded_body_*, whichgenerated_bodychecks, and its chunks and trailers inaws_chunked.repeatsanswers as many requests as match it. A response withserves_rangesanswers a ranged GET with that window of its body.body_base64, so an adapter that cannot generate bodies still runs the small cases. An adapter's time grows with the bytes a case moves.body_result: "fingerprint"makes an adapter report a read by its fingerprint.Decisions:
If-Match.aws-chunkedis decoded. An S3 write may comeaws-chunked, and that alternative grades the decoded payload.Cases, 30 on every profile:
CannotVerifyCopySource, not the 413 of a direct write.All 30 cases were verified live against S3, S3 Express and flat and HNS Azure accounts, with the services' stored CRC64 checked for the largest writes. The Azure C++ SDK passes all 24 Azure cases and the AWS C++ CRT client all 6 S3 cases; the borink adapter passes the 14 From URL cases and reports the generated-body cases unsupported. The grader stays near 6 MB throughout.