Repository navigation
Have adapters write a large read to a grader socket, not a checksum. - #16
Merged
Merged
Conversation
A call with body_result "fingerprint" now reaches the adapter as body_sink, a loopback address. The adapter copies the body there and the grader fingerprints it, so no adapter computes a CRC or minds its byte order. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
That commit, on borink-org/object-storage#43, writes large reads to the body sink. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large read no longer makes the adapter compute a checksum. The grader opens a loopback socket and passes its address to the adapter as
body_sink, in place ofbody_result: "fingerprint". The adapter connects, copies the body it read into the connection, closes it, and reports its result without a body. The grader fingerprints the bytes as they arrive and addsbody_lengthandbody_crc64nvme_base64to the result'svalue, wheregenerated_bodychecks them as before.Adapters reporting a CRC-64/NVME had to get its byte order right: the Azure SDK and the borink crate hand out little-endian bytes, and the fingerprint is big-endian. Two adapters needed a reversal, and one agent got it wrong. Now an adapter only copies bytes:
io::copyinto aTcpStreamin Rust, a small socket helper in C++.generated_bodycheck fails. A test covers an adapter that never writes to it.large.jsonstill saysbody_result: "fingerprint", so no live evidence needs a new run.