Skip to content

Remove stale RedisSimpleQueue from __all__ - #856

Merged
brainix merged 1 commit into
brainix:masterfrom
Master-Norna:fix/stale-redis-simple-queue-in-all
Oct 10, 2026
Merged

brainix merged 1 commit into
brainix:masterfrom
Master-Norna:fix/stale-redis-simple-queue-in-all

Conversation

@Master-Norna

Copy link
Copy Markdown
Contributor

Summary

from pottery import * raises AttributeError on current master:

AttributeError: module 'pottery' has no attribute 'RedisSimpleQueue'

Cause

PR #818 ("Upgrade requirements and remove my idiotic queue") deleted
pottery/queue.py and its import in __init__.py, but left
'RedisSimpleQueue' behind in __all__. A star import resolves every
name in __all__ against the module, so it now fails.

Fix

Remove the stale entry from __all__ (one line).

Verification

  • Before: python -c "from pottery import *" -> AttributeError
  • After: star import succeeds, pottery.__all__ lists 28 names
  • Grepped the whole repo: no remaining references to RedisSimpleQueue
    (including tests)

No behavioral change for any other import path; only the star import,
which was broken, is fixed.

@Master-Norna

Copy link
Copy Markdown
Contributor Author

Hi @brainix — this is a one-line cleanup: #818 removed pottery/queue.py but left 'RedisSimpleQueue' in __all__, which makes from pottery import * raise AttributeError. Verified locally: the star import works after the change, and no other references to the name remain in the repo.

The CI run is currently pending approval for first-time contributors — could you approve it so the checks can run? Thanks!

@brainix
brainix merged commit 7c589f3 into brainix:master Oct 10, 2026
5 checks passed
@brainix

brainix commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants