fix: resolve top-level resource classes in mypy - #710
Open
mrlonely (mameikagou) wants to merge 2 commits into
Open
fix: resolve top-level resource classes in mypy#710mrlonely (mameikagou) wants to merge 2 commits into
mrlonely (mameikagou) wants to merge 2 commits into
Conversation
mrlonely (mameikagou)
marked this pull request as ready for review
August 22, 2026 03:05
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b64b6728b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #498.
The package root wildcard-imported generated API
TypedDicts with the same names asExperiment,Dataset,Project, andPrompt. Runtime imports selected the resource classes, but mypy selected the generated types.This explicitly re-exports the non-conflicting generated types so the four resource names resolve consistently, while keeping every existing generated name available at the package root. A type regression test covers the public resource methods.
Validation:
uv run nox -s test_typesuv run nox -s pylint