Skip to content

add gateway cli option for bt - #326

Open
Ken Jiang (knjiang) wants to merge 3 commits into
mainfrom
08-19-add_gateway_cli_option_for_bt
Open

add gateway cli option for bt#326
Ken Jiang (knjiang) wants to merge 3 commits into
mainfrom
08-19-add_gateway_cli_option_for_bt

Conversation

@knjiang

@knjiang Ken Jiang (knjiang) commented Aug 19, 2026

Copy link
Copy Markdown

add gateway cli option for bt

tested manually:

./target/debug/bt-gateway-test login --oauth

./target/debug/bt-gateway-test gateway setup claude \
    --gateway-url https://gateway.staging.braintrust.dev

<tested model switching etc.> 

./target/debug/bt-gateway-test gateway setup codex \
    --gateway-url https://gateway.staging.braintrust.dev

<tested model switching etc.>

Copy link
Copy Markdown
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@knjiang
Ken Jiang (knjiang) marked this pull request as ready for review August 19, 2026 14:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2547d30279

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread src/gateway.rs
Comment thread src/gateway.rs Outdated
Comment thread src/main.rs
Comment thread src/gateway.rs Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Latest downloadable build artifacts for this PR commit 2547d30279e1:

Available artifact names
  • artifacts-build-global
  • artifacts-build-local-x86_64-apple-darwin
  • artifacts-build-local-aarch64-pc-windows-msvc
  • artifacts-build-local-x86_64-pc-windows-msvc
  • artifacts-build-local-x86_64-unknown-linux-musl
  • artifacts-build-local-x86_64-unknown-linux-gnu
  • artifacts-build-local-aarch64-apple-darwin
  • artifacts-build-local-aarch64-unknown-linux-gnu
  • artifacts-plan-dist-manifest
  • cargo-dist-cache

@knjiang

Copy link
Copy Markdown
Author

Codex (@codex) review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2862a83add

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread src/gateway.rs
Comment on lines +162 to +165
.entry("env".to_string())
.or_insert_with(|| TomlValue::Table(toml::map::Map::new()))
.as_table_mut()
.ok_or_else(|| anyhow!("field 'env' in {} must be a TOML table", path.display()))?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Store the provider key where Codex can read it

The updated provider block sets env_key = "BRAINTRUST_GATEWAY_API_KEY", but the secret is only written into a top-level [env] table rather than the environment of future Codex processes. Validating the generated file with Codex 0.144 shows that --strict-config rejects [env] as an unknown configuration field, while a normal invocation ignores it and fails with Missing environment variable: BRAINTRUST_GATEWAY_API_KEY; therefore bt gateway setup codex still reports success without producing usable authentication. Fresh evidence since the earlier comment is that the newly added provider now explicitly references this unavailable variable, so adding the provider block did not resolve the authentication failure.

Useful? React with 👍 / 👎.

Comment thread src/gateway.rs
Comment thread src/gateway.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant