Skip to content

feat(router): add SaladCloud as an OpenAI-compatible provider - #419

Open
Maksim (mgorkii-nlplogix) wants to merge 1 commit into
braintrustdata:mainfrom
mgorkii-nlplogix:feat/saladcloud-provider
Open

feat(router): add SaladCloud as an OpenAI-compatible provider#419
Maksim (mgorkii-nlplogix) wants to merge 1 commit into
braintrustdata:mainfrom
mgorkii-nlplogix:feat/saladcloud-provider

Conversation

@mgorkii-nlplogix

Copy link
Copy Markdown

Summary

  • recognize saladcloud as an OpenAI-compatible provider kind
  • expose https://ai.salad.cloud/v1 as its default endpoint
  • list SaladCloud among the router's documented OpenAI-compatible providers
  • add focused coverage for the provider classification and endpoint

This change is limited to the public router client. The SaladCloud rollout is intended to expose only qwen3.6-35b-a3b; canonical model-catalog and hosted-gateway configuration remain separate from this repository.

Validation

  • cargo +1.97.1 test -p braintrust-llm-router — 204 unit tests and 15 integration tests passed; 1 doc test ignored
  • cargo +1.97.1 clippy -p braintrust-llm-router --all-targets -- -D warnings
  • cargo +1.97.1 fmt --all -- --check
  • git diff --check

Documentation

@mgorkii-nlplogix
Maksim (mgorkii-nlplogix) marked this pull request as ready for review August 10, 2026 13:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 308d7e3942

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

| "databricks"
| "cohere"
| "openrouter"
| "saladcloud"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Apply the SaladCloud endpoint during provider construction

When callers use the public factory as create_provider("saladcloud", None, ...), this new match selects the OpenAI-compatible branch in router.rs, but OpenAIProvider::from_config retains OpenAIConfig::default() and therefore targets https://api.openai.com/v1; the new openai_compatible_endpoint entry is not used anywhere in that construction path. Consequently, omitting the documented-optional endpoint sends requests and the SaladCloud bearer credential to OpenAI instead of SaladCloud, so the factory should apply this default endpoint or reject a missing endpoint.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant