feat(router): add SaladCloud as an OpenAI-compatible provider - #419
feat(router): add SaladCloud as an OpenAI-compatible provider#419Maksim (mgorkii-nlplogix) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 308d7e3942
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| | "databricks" | ||
| | "cohere" | ||
| | "openrouter" | ||
| | "saladcloud" |
There was a problem hiding this comment.
Apply the SaladCloud endpoint during provider construction
When callers use the public factory as create_provider("saladcloud", None, ...), this new match selects the OpenAI-compatible branch in router.rs, but OpenAIProvider::from_config retains OpenAIConfig::default() and therefore targets https://api.openai.com/v1; the new openai_compatible_endpoint entry is not used anywhere in that construction path. Consequently, omitting the documented-optional endpoint sends requests and the SaladCloud bearer credential to OpenAI instead of SaladCloud, so the factory should apply this default endpoint or reject a missing endpoint.
Useful? React with 👍 / 👎.
Summary
saladcloudas an OpenAI-compatible provider kindhttps://ai.salad.cloud/v1as its default endpointThis change is limited to the public router client. The SaladCloud rollout is intended to expose only
qwen3.6-35b-a3b; canonical model-catalog and hosted-gateway configuration remain separate from this repository.Validation
cargo +1.97.1 test -p braintrust-llm-router— 204 unit tests and 15 integration tests passed; 1 doc test ignoredcargo +1.97.1 clippy -p braintrust-llm-router --all-targets -- -D warningscargo +1.97.1 fmt --all -- --checkgit diff --checkDocumentation