fix automations - #434
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6335cb136
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a785c1bf36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| } | ||
|
|
||
| fn google_public_schema_name(source_name: &str) -> Result<String, String> { | ||
| let public_name = match source_name.strip_prefix("V1main") { |
There was a problem hiding this comment.
When a Discovery schema uses the V1Main... spelling, this function leaves the internal prefix intact because it only matches V1main. The provider-update workflow explicitly rejects both spellings with V1(Main|main), so generation of such a schema will produce prefixed Rust or TypeScript names and then fail the semantic-policy step rather than normalizing them; handle both spellings here and in collision detection.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1dfaafebc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| id: claude | ||
| timeout-minutes: 30 | ||
| uses: anthropics/claude-code-action@fbda2eb1bdc90d319b8d853f5deb53bca199a7c1 # v1.0.140 | ||
| uses: ./.github/actions/claude-code-with-retry |
There was a problem hiding this comment.
When the first Claude invocation runs until the existing 30-minute step timeout in provider-type-codex-autofix.yml, GitHub cancels this entire composite-action invocation, so the retry inside the action never runs; the same issue affects the other converted phases with their existing timeout-minutes values. Increase the caller's total timeout to cover both attempts and enforce a separate bound per attempt so late failures can actually be retried.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd212caa85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| if [ "${{ steps.plan_validation.outcome }}" != "success" ] || | ||
| [ "${{ steps.stage_plan.outcome }}" != "success" ] || | ||
| [ "${{ steps.post_implementation_plan.outcome }}" != "success" ] || | ||
| [ "${{ steps.verification_report.outcome }}" != "success" ] || | ||
| [ "${{ steps.verification_report.outputs.verdict }}" != "pass" ] || |
There was a problem hiding this comment.
When the validated plan requires live capture but the capture_cases step fails, its output is empty, so the live/transform checks are bypassed and this condition does not even downgrade the PR to draft. If the remaining checks pass, the workflow can therefore publish the change as ready with the auto-sync label despite never running the planned capture; require successful capture-case extraction before publication.
AGENTS.md reference: AGENTS.md:L138-L141
Useful? React with 👍 / 👎.
| - name: Run Claude Code | ||
| id: primary | ||
| continue-on-error: true | ||
| uses: anthropics/claude-code-action@fbda2eb1bdc90d319b8d853f5deb53bca199a7c1 |
There was a problem hiding this comment.
If the primary Claude invocation stalls rather than returning a failure, this child step has no timeout, so execution never reaches the retry before the caller job exhausts its overall runtime. The fresh revision removes all five phase-level timeouts from update-provider-types.yml and the autofix step timeout but adds no per-attempt bound here, leaving the advertised bounded retry ineffective for hung invocations; enforce an independent limit for each child attempt while allowing the caller enough time for both.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee66bba288
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| id: claude | ||
| timeout-minutes: 30 | ||
| uses: anthropics/claude-code-action@fbda2eb1bdc90d319b8d853f5deb53bca199a7c1 # v1.0.140 | ||
| uses: ./.github/actions/claude-code-with-retry |
There was a problem hiding this comment.
In the inspected propose job, line 115 checks out the reviewed PR head, so this relative uses: loads action.yml from that mutable head and then passes it BRAINTRUST_API_KEY at line 178. A repository member can alter an eligible bot PR's branch and invoke the supported manual retry command, causing arbitrary composite-action steps to execute with the secret without merging the action change to main; reference a trusted, immutable revision of the wrapper instead.
Useful? React with 👍 / 👎.
2 participants
No description provided.