Repository navigation
fix status and use devplane as source of truth - #489
Open
patelspratik wants to merge 1 commit into
Open
patelspratik wants to merge 1 commit into
patelspratik wants to merge 1 commit into
Conversation
patelspratik
force-pushed
the
fixwrongstatus
branch
2 times, most recently
from
October 2, 2026 23:21
49cbfdf to
e2479dc
Compare
patelspratik
force-pushed
the
fixwrongstatus
branch
from
October 12, 2026 22:29
e2479dc to
39f22d0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 33.51% 34.86% +1.35%
==========================================
Files 153 156 +3
Lines 21654 21787 +133
==========================================
+ Hits 7257 7597 +340
+ Misses 13624 13396 -228
- Partials 773 794 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
patelspratik
force-pushed
the
fixwrongstatus
branch
5 times, most recently
from
October 13, 2026 22:00
836f146 to
797360b
Compare
patelspratik
commented
Oct 13, 2026
|
|
||
| // toProtoNodeSpec converts the local HardwareProfile (used for collection, display, | ||
| // persistence) to the generated proto NodeSpec for RPC calls. | ||
| func toProtoNodeSpec(hw *HardwareProfile) *nodev1.NodeSpec { |
Contributor
Author
There was a problem hiding this comment.
this is a move from pkg/cmd/register/rpcclient.go
patelspratik
commented
Oct 13, 2026
|
|
||
| func (p staticTokenProvider) GetAccessToken() (string, error) { return p.token, nil } | ||
|
|
||
| func Test_toProtoNodeSpec(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
move from pkg/cmd/register/rpcclient_test.go
patelspratik
commented
Oct 13, 2026
Contributor
Author
There was a problem hiding this comment.
new dev-plane client centralization. some of this came from pkg/cmd/register/rpcclient.go
patelspratik
force-pushed
the
fixwrongstatus
branch
from
October 13, 2026 22:30
797360b to
6fb2cf6
Compare
patelspratik
force-pushed
the
fixwrongstatus
branch
from
October 13, 2026 22:34
6fb2cf6 to
063e236
Compare
patelspratik
marked this pull request as ready for review
October 13, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed mismatch between UI and CLI because CLI was still using brev-deploy/workspaces to drive status
new dev-plane client and site updates, made the PR a bit chatty
store.NewDevPlaneClientbuilds one authenticated ConnectRPC bundle (Instances, Environments, Organizations, ExternalNodes, ManagedSecrets) over a shared HTTP client with CLI attribution params.small bug fix that's failing on main from merge conflicts
http_response_error_test.goassertions updated to the current 401 contract — fix: show readable auth error on 401 instead of raw json #484 replaced the raw"401 Unauthorized"base message with friendly copy but left fix: clarify the error when an API key is no longer valid #490's assertions pinned to the old text, so any branch containing both commits was red.