Repository navigation
fix: validate instance is scalable before scale - #505
Open
shivamj-del wants to merge 1 commit into
Open
shivamj-del wants to merge 1 commit into
shivamj-del wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
brev scalesends the resize request for any instance and prints "Instance scaled to ", even when the provider can't change the type of an existing instance (e.g. Crusoe, AWS spot). The backend then stops the instance, fails, and leaves it stopped on its old type.Fix
instanceTypeInfo.sub_location_type_changeablefrom the workspace. dev-plane sets it only for instance types whose provider can change type in place (AWS on-demand, GCP).--gpuand--cpu). If it's false or missing, fail withinstance "<name>" does not support scale; create a new instance with the desired type instead.