Repository navigation
Conversation
Signed-off-by: Deepak Jain <deepujain@gmail.com>
Author
|
This prerequisite is ready for the repository's review and CI process. All eight upstream workflows are held for maintainer approval of the fork contribution; none has run yet. Please approve the runs using existing Actions write authority. I have no upstream write/approval permission. Exact candidate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full CI on current main is blocked before this dependency's product changes: the test workflow references an action rejected by enterprise policy, and merged #484 changed Brev UnauthorizedError output while two existing tests still require raw 401/JSON text.
Use the enterprise-allowlisted immutable
8398a7/action-slackrevision with the existing webhook and failure-only notification behavior. Update the test workflow's checkout to v4 (the existing #304 proposal) so actionlint accepts the modified workflow. Keep the same tests, coverage and artifacts. Update the stale auth assertions to verify #484's intended API-key/login guidance and absence of raw control-plane error output; production authentication code is unchanged.Required validation dependency for SSH Include recovery #507, related to NVIDIA/NemoClaw#13090.
Evidence:
ravsamhq/notify-slack-action@v1as forbidden by enterprise policy. Base main's test workflow also has startup failure.a0190d24655f57f327778f7708d8a6f634afdb1alegacy CI logs fail the same HTTPResponseError assertions. Equivalent local focused tests reproduce on base and pass with these assertion corrections.go test -race ./pkg/store -run '^TestHTTPResponseError_' -count=1, gofumpt, git diff check and actionlint of the modified workflow pass. Hosted full CI and code-owner review remain required.