Skip to content

Change error types to use core::error::Error - #2871

Merged
briansmith merged 1 commit into
briansmith:mainfrom
jschillem:remove-std-feature
Jul 22, 2026
Merged

briansmith merged 1 commit into
briansmith:mainfrom
jschillem:remove-std-feature

Conversation

@jschillem

@jschillem jschillem commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

With core::error::Error being stabilized in Rust 1.81, the error types no longer need to depend on std for this trait.

Removing this also renders the std unnecessary for any library consumers as the only usage of the std is now for test logging. Though it may make sense to leave the std flag to avoid breakages.

@briansmith briansmith left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/lib.rs
Comment thread src/testutil.rs
Comment thread tests/error_tests.rs Outdated
Comment thread Cargo.toml
Comment thread src/deprecated_test.rs Outdated
@jschillem
jschillem requested a review from briansmith July 18, 2026 00:30
@codecov

codecov Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.44%. Comparing base (c866e60) to head (cd54e96).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2871   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         204      204           
  Lines       20402    20407    +5     
  Branches      521      521           
=======================================
+ Hits        19676    19682    +6     
  Misses        602      602           
+ Partials      124      123    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/error/mod.rs Outdated
Comment thread src/lib.rs
@briansmith

Copy link
Copy Markdown
Owner

In addition to the change mentioned in the review, please squash the commits into a single commit, and update the commit message to remove "and removing the std feature".

@jschillem jschillem changed the title Change errors to use core::error::Error, and removing the std feature Change error types to use core::error::Error Jul 20, 2026
@jschillem
jschillem force-pushed the remove-std-feature branch from ae8280a to cd54e96 Compare July 20, 2026 23:33
@jschillem
jschillem requested a review from briansmith July 20, 2026 23:38

@briansmith briansmith left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@briansmith
briansmith merged commit 840167e into briansmith:main Jul 22, 2026
257 of 318 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants