Change error types to use core::error::Error - #2871
Merged
Merged
Conversation
briansmith
requested changes
Jul 17, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 204 204
Lines 20402 20407 +5
Branches 521 521
=======================================
+ Hits 19676 19682 +6
Misses 602 602
+ Partials 124 123 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
briansmith
requested changes
Jul 20, 2026
Owner
|
In addition to the change mentioned in the review, please squash the commits into a single commit, and update the commit message to remove "and removing the |
core::error::Error, and removing the std featurecore::error::Error
jschillem
force-pushed
the
remove-std-feature
branch
from
July 20, 2026 23:33
ae8280a to
cd54e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
core::error::Errorbeing stabilized in Rust 1.81, the error types no longer need to depend onstdfor this trait.Removing this also renders the
stdunnecessary for any library consumers as the only usage of thestdis now for test logging. Though it may make sense to leave thestdflag to avoid breakages.