fix(browser): resolve HTTP CDP URLs#113
Open
MagMueller wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BU_CDP_URL=http://...as a DevTools HTTP endpoint and resolve its WebSocket URL through/json/versionBU_CDP_URL=ws://...compatibility and keepBU_CDP_WSas the highest-priority direct WebSocket settingPreviously an HTTP
BU_CDP_URLwas passed directly tonew WebSocket, which attempted an upgrade on the HTTP root instead of querying/json/version. This matches the public browser-harness endpoint contract.Validation
bun testinpackages/bcode-browser: 16 pass, 8 environment-gated skipsbunx oxlint packages/bcode-browser/test/connect-env.test.ts: cleanSummary by cubic
Fixes connection to Chrome when
BU_CDP_URLis an HTTP DevTools endpoint by resolving its WebSocket URL via/json/version. Uses a single connection deadline for discovery and WebSocket open, adds retries until the deadline, and clearer 403 permission errors, while keepingBU_CDP_WSpriority andBU_CDP_URLWebSocket compatibility.BU_CDP_URLthrough/json/versionto obtainwebSocketDebuggerUrl.BU_CDP_WSoverBU_CDP_URL; accept WebSocket values inBU_CDP_URL.Written for commit d3e7b76. Summary will update on new commits.