Light mode: drop washed-out hero glow + fix scoped scheme overrides#12
Merged
Conversation
Building on the surface-definition work, fix the real "livid" cause and a related Vue scoped-CSS bug. - The pink hero glow (glowpulse animation, opacity .55->.8) is a dark-scheme signature; on near-white it became a washed-out pink cloud behind the wordmark. It is now hidden in light mode. - Root cause of several light-mode misses: a scoped selector of the form :global(html-state) .btv-child compiles (Vue scoped CSS) to just the html-state element, dropping the child — so the light overrides for the glow and the nav/pill/footer overlays never reached the landing subtree. Drive all scheme-specific values (overlays, card rest shadow, glow display) through CSS variables set on the two html states and consume them on the elements, which cascades correctly. Verified light: glow hidden, cards have a rest shadow and still lift on hover, pills use the dark-on-light overlay; dark: glow shown, no card rest shadow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the VitePress landing page styling to keep the hero “glow” as a dark-scheme signature while ensuring light mode avoids the washed-out halo and correctly applies scheme-specific overlays via CSS variables.
Changes:
- Hide the hero glow in light mode (keep it visible in dark mode) via a scheme-controlled CSS variable.
- Route landing-local overlay colors (hover wash, pills, footer tint) through variables set per scheme to avoid scoped-selector pitfalls.
- Apply a light-mode “rest” shadow for principle/project cards via a scheme-controlled CSS variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The light-mode commit that stranded after #11 merged. Landing.vue only; lockfile unchanged; build green.
The "livid" fix
The pink hero glow pulses opacity .55→.8 (the
glowpulseanimation). On dark plum it's the signature halo; on near-white it became a washed pink cloud behind the wordmark, making the brand colors look livid. It's now hidden in light, kept in dark.Scoped-CSS bug it surfaced
A
:global(html…) .btv-childscoped selector compiles (Vue) to justhtml…— the child class is dropped. So the light overrides for the glow and the nav/pill/footer overlays were landing on<html>(ignored), never reaching the landing. Rerouted all scheme-specific values (glow display, card rest shadow, overlays) through CSS variables set on the two html states, which cascades correctly.Verified: light → glow
display:none, cards have a rest shadow and still lift on hover, pills use the dark-on-light overlay; dark → glow shown, no card rest shadow.