Repository navigation
Move to Bubilator88Core 1.1.0 - #197
Merged
Merged
Conversation
Picks up the ADPCM delta-N low-byte fix (bubio/Bubilator88Core#22): writing the register pair's low byte first (the common order, and the only one riskable after a reset) used to lose it whenever the high byte was still 0x00, flooring delta-N to a multiple of 0x0100 instead of the value software wrote. あたしのぱ・ぴ・ぷ・ぺ・ぽ hit this on its one post-reset write and played its 66-second ADPCM stream 2.3% slow, falling behind the RTC-paced animation. Also points docs/develop at the merged writeup (bubio/dev-docs#17). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project.pbxprojのminimumVersionとPackage.resolved）。docs/developを bubio/dev-docs#17（FMGEN_FORK_COMPARISON.mdへの追記）のマージ後コミットに更新。Test plan
xcodebuild -resolvePackageDependencies -scheme Bubilator88で 1.1.0 を解決xcodebuild -scheme Bubilator88 -configuration Debug build成功swift test（928 tests）とscripts/regression_compare.py（20/20 PASS）済み（Keep the ADPCM delta-N low byte when it is written first Bubilator88Core#22）🤖 Generated with Claude Code