Show D88 disk images in Finder with their title screen - #200
Merged
Merged
Conversation
The Quick Look thumbnail extension now also handles .d88: it boots the disk with Bubilator88Core's BootSnapshot (V2, 4MHz, no Sound Board II, 3 second budget) and draws the frame it settles on. Disks that do not boot to anything, or leave a nearly black screen, keep the generic icon. - Declare com.bubio.bubilator88.d88-disk-image as an exported type, so another app's exported d88 type does not take precedence over it - Let the sandboxed extension read the BIOS ROMs in ~/Library/Application Support/Bubilator88/ through a read-only temporary exception, and move the ROM file table to Shared/BIOSFiles so the app and the extension share it - Skip files over 16 MB and run at most two boots at once - Require Bubilator88Core 1.2.0 for BootSnapshot Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Used to eyeball a batch of BootTester --snapshot captures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.d88にも対応した。ディスクをその場で起動し（Bubilator88Core 1.2.0 のBootSnapshot。V2・4MHz・サウンドボード II なし・期限 3 秒）、落ち着いた時点の画面をサムネイルにする。起動しない・ほぼ黒画面のディスクは汎用アイコンのままcom.bubio.bubilator88.d88-disk-imageを exported で宣言。他アプリの exported 宣言に負けないようにするため~/Library/Application Support/Bubilator88/の BIOS ROM を読めるよう、読み取り専用の temporary exception を追加（Developer ID 配布が前提）。ROM ファイルの対応表はShared/BIOSFiles.swiftに移し、アプリと拡張で共有scripts/ppm_contact_sheet.pyを追加docs/developを更新（設計と実測:QUICKLOOK_DISK_THUMBNAIL_PLAN.md）Test plan
QLThumbnailGenerator経由でテスト用.d88のサムネイル生成を確認（タイトル画面、LION は失敗扱いで汎用アイコン）.b88sのサムネイルが従来どおり生成されることを確認swift test940 件、/regression20 件 PASS🤖 Generated with Claude Code