IVS-820 - Pending Hourglass error#308
Merged
Merged
Conversation
…n is terminal A not-yet-run check resolved to grey 'not validated' mid-run once the Model existed. Gate it to the pending hourglass on request.status (not progress: progress hits 100 one task before COMPLETED). Applied post-combine so a sibling warning is never hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a file is still validating, checks that hadn't run yet were showing the grey
"not validated" icon instead of the hourglass. This makes them look skipped when they
were really just still pending. Now they show the hourglass until the run is actually
finished, then settle to their real result (green/red/grey).
The fix waits for the validation's status to say it's done,
because the bar reaches 100% a moment before the run truly finishes. It's a
backend-only change (the frontend already knows how to draw the hourglass), so it
fixes this everywhere the statuses are shown, not just the dashboard.