-
Notifications
You must be signed in to change notification settings - Fork 0
SBOM / release conformance: the seven rows under CLOUD-608, in one land #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6d3b0a6
fix(gate): drop the unsatisfiable standard, and refuse one as a preco…
wenzowski c12bf05
fix(sbom): one entry per thing depended on, not one per reference site
wenzowski e38b9ff
fix(sbom): supplier from the resolution, originator from the manifest
wenzowski 226308e
fix(sbom): copyright from the bytes the lockfile pins, NONE where the…
wenzowski 2ca2962
fix(sbom): concluded license from cargo metadata, and the slash form …
wenzowski 8310b62
fix(sbom): license and copyright for the 9 pinned actions, from a gat…
wenzowski c23b250
fix(config): promote sbom-ntia-conformance to deny, in the change tha…
wenzowski ff910ae
fix(sbom): a portable roots reader, and a coordinate the exclusion co…
wenzowski b792c19
fix(sbom): key the action table the way the pin exemption already spe…
wenzowski 6ccdc89
test(sbom): cover the pin-length arm, which the absent-pin case could…
wenzowski 6fda6af
chore(bench): record the cost of tests/sbom.bats, from a complete run
wenzowski 5c78456
fix(gate): a receipt that cannot be written is not a nonconformance
wenzowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
crates/batten/tests/fixtures/repos/attribution-coordinate/sbom-actions.tsv.in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # A pinned action written as a data-table key rather than as a `uses:` line | ||
| # (CLOUD-667). ONE field, so the `@[0-9a-f]{40}` term already exempts it — which | ||
| # is why the table is keyed this way and the exclusion needed no widening. | ||
| jdx/mise-action@9dda3952d607125725deac9ec10a5f0e245d266b MIT NONE |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Regenerate the benchmark report with a matching suite count.
Line 9 declares 158 suites, but the table contains 159 suite rows from Line 14 through Line 172.
mise-tasks/suite-bench.shderives this count from the emitted rows, so the committed report is inconsistent. Regenerate it withmise run suite-bench --writeand verify the summary matches the table.🤖 Prompt for AI Agents