Skip to content

MBS-11472: Escape section name in activity selector #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PM84 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MBS-11472: Escape section name in activity selector #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mod_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ public function definition(): void {
// Gets only sections with content.
foreach ($cm->get_sections() as $sectionnum => $section) {
$sectioninfo = $cm->get_section_info($sectionnum);
$s['name'] = $sectioninfo->name;
// Not escaped here, the template escapes it.
$s['name'] = format_string($sectioninfo->name, true, ['context' => $this->context, 'escape' => false]);
if (empty($s['name'])) {
$s['name'] = get_string('section') . ' ' . $sectionnum;
}
Expand Down
2 changes: 1 addition & 1 deletion templates/activityselector.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
<div class="card-text">{{#str}} activity, core {{/str}}
<select id="learningmap-activity-selector">
{{#sections}}
<optgroup label="{{#shortentext}} 30, {{{name}}} {{/shortentext}}">
<optgroup label="{{#shortentext}} 30, {{name}} {{/shortentext}}">
{{#coursemodules}}
{{^completionenabled}}
<option value="{{id}}" disabled class="learningmap-disabled-activity" title="{{#str}} nocompletionenabled, learningmap {{/str}}">{{#shortentext}} 30, {{{name}}} {{/shortentext}}</option>
Expand Down
Loading