build.rs: replace manual Option::filter with .filter() - #1667
Open
tangaac wants to merge 2 commits into
Open
Conversation
Newer clippy flags `and_then(|x| if cond { None } else { Some(x) })` as
`manual_filter`. Replace with `.filter(|x| !cond)` to satisfy
`-D warnings`.
Contributor
|
The lint fixed is |
This comment was marked as outdated.
This comment was marked as outdated.
tangaac
force-pushed
the
fix/manual-filter-lint
branch
from
September 1, 2026 10:10
e4e9635 to
53d434f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newer clippy versions flag
and_then(|x| if cond { None } else { Some(x) })with the
manual_filterlint. With-D warningsin CI, this breaks thebuild on newer toolchains.
Replace with
.filter(|x| !cond)inbuild.rs.Verification
cargo clippy --workspace --features=all-apis -- -D warningspasses.