-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update rust-dev-deps #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -84,7 +84,7 @@ criterion = { version = "0.5", features = ["html_reports"] } | |
| # must match the locked wasm-bindgen version (bump this, Cargo.lock and the | ||
| # runner pin in ci.yml together). | ||
| [target.'cfg(target_arch = "wasm32")'.dev-dependencies] | ||
| wasm-bindgen-test = "=0.3.71" | ||
| wasm-bindgen-test = "=0.3.79" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stale cargo-vet exemptions in supply-chain/config.toml: lines 321-351 still exempt only 0.3.71, 0.2.121 and 0.4.71, while the new pin pulls in wasm-bindgen-test/-macro 0.3.79, wasm-bindgen* 0.2.129 and wasm-bindgen-futures 0.4.79. When the wasm-bindgen-test = "=0.3.79"
# and update supply-chain/config.toml exemptions:
# wasm-bindgen / -macro / -macro-support / -shared / -test-shared -> 0.2.129
# wasm-bindgen-test / -test-macro -> 0.3.79
# wasm-bindgen-futures -> 0.4.79Prompt for LLMTalk to Kody by mentioning @kody Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction. |
||
|
|
||
| [features] | ||
| default = ["compression", "checksum", "messagepack"] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch in .github/workflows/ci.yml: Cargo.toml now pins
wasm-bindgen-test = "=0.3.79"and Cargo.lock resolves wasm-bindgen to 0.2.129, but line 88 still sets WASM_BINDGEN_VERSION to "0.2.121" with the old SHA256 on line 90. When the wasm32 job runs, the 'Guard wasm-bindgen lockfile drift' step (ci.yml lines 104-110) seescargo pkgid wasm-bindgen= 0.2.129 ≠ 0.2.121 and exits 1, and even without the guard the 0.2.121 wasm-bindgen-test-runner rejects the 0.2.129 ABI, so the wasm32 ratio-product vector test never runs. Fix: in this PR, set WASM_BINDGEN_VERSION to "0.2.129" and WASM_BINDGEN_SHA256 to the checksum of the 0.2.129 release tarball, as the comment on lines 81-85 requires.Prompt for LLM
Talk to Kody by mentioning @kody
Was this suggestion helpful? React with 👍 or 👎 to help Kody learn from this interaction.