Skip to content

chore(deps): skip syn 2 and windows-sys 0.52 in cargo-deny duplicate bans (LAB-6648) - #92

Merged
27Bslash6 merged 1 commit into
mainfrom
lab-6648-deny-duplicate-skips
Sep 30, 2026
Merged

27Bslash6 merged 1 commit into
mainfrom
lab-6648-deny-duplicate-skips

Conversation

@27Bslash6

@27Bslash6 27Bslash6 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

This PR changes only the cargo-deny configuration in deny.toml. It does not modify any public APIs, library code or runtime behavior.

Summary

It adds two version-scoped entries to bans.skip so that pending dependency updates (serde, thiserror, cbindgen) pass cargo deny check bans. multiple-versions = "deny" stays in effect for every other crate. It also updates the comment on the existing getrandom@0.2 skip.

Changes

New skip entries in deny.toml:

Skip Older version pulled by Newer version pulled by Scope
syn@2 cbindgen (build-dep), zeroize_derive serde_derive, thiserror-impl (syn 3) Proc-macro and build-time only
windows-sys@0.52 tempfile → rustix/errno clap's anstyle crates (0.61) Both under the cbindgen build-dep; Windows-only bindings

Each entry names only the older major version, the same way the existing getrandom@0.2 and winnow@0.7 skips do. A third version of syn or windows-sys still fails the check, as does a duplicate of any other crate.

Updated comment on getrandom@0.2:

  • The comment previously named only the 0.2 vs 0.4 split.
  • It now covers both newer majors that tempfile pulls in through cbindgen: 0.4.x up to cbindgen 0.29.2, and 0.3.x from 0.29.4.
  • The reason field is unchanged.

Impact

  • Serde, thiserror and cbindgen can be updated without waiting for the whole dependency graph to move to syn 3.
  • The new skips affect only build-time and proc-macro dependencies, not the runtime dependency surface.
  • Against the current main lockfile, cargo-deny reports unnecessary-skip for syn and unmatched-skip for windows-sys. This is expected until the updates land. Later, the same warnings will show when a skip has gone stale and can be removed.

…bans (LAB-6648)

serde 1.0.229 and thiserror 2.0.21 move their derive crates to syn 3 while
cbindgen and zeroize_derive stay on syn 2. cbindgen 0.29.4 moves tempfile's
rustix/errno to windows-sys 0.52 while clap's anstyle crates stay on 0.61.
Both splits fail multiple-versions = "deny" on routine updates.

Skip the older major of each, version-scoped, so any further duplicate still
fails. Also correct the getrandom@0.2 comment, which named only the 0.4 split.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: cachekit-io/cachekit-core/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7a13fefa-a052-42cf-81e6-09e8e8678e99

📥 Commits

Reviewing files that changed from the base of the PR and between f68ca10 and 9badf7a.

📒 Files selected for processing (1)
  • deny.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The dependency ban skip list retains two exemptions with updated conflict descriptions. It adds exemptions for syn@2 and windows-sys@0.52, with dependency contexts and reasons.

Changes

Dependency ban configuration

Layer / File(s) Summary
Update dependency skip entries
deny.toml
The skip list retains getrandom@0.2 and winnow@0.7 with updated conflict descriptions. It adds skip entries for syn@2 and windows-sys@0.52.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9badf

The audit policy allows the specified dependency versions while continuing to deny other duplicates. No identified issue blocks merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 9badf

The change affects 1 system.

Changed systems: deny.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — deny.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in deny.toml: The getrandom@0.2 and winnow@0.7 skip entries remain, with updated conflict descriptions. The list adds skip entries for syn@2 and windows-sys@0.52, citing their dependency contexts and reasons.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarises the main change: adding cargo-deny exemptions for syn 2 and windows-sys 0.52. It is specific and related to the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kodus-27b

kodus-27b Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@27Bslash6
27Bslash6 merged commit b531ea3 into main Sep 30, 2026
34 checks passed
@27Bslash6
27Bslash6 deleted the lab-6648-deny-duplicate-skips branch September 30, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant