chore(deps): skip syn 2 and windows-sys 0.52 in cargo-deny duplicate bans (LAB-6648) - #92
Conversation
…bans (LAB-6648) serde 1.0.229 and thiserror 2.0.21 move their derive crates to syn 3 while cbindgen and zeroize_derive stay on syn 2. cbindgen 0.29.4 moves tempfile's rustix/errno to windows-sys 0.52 while clap's anstyle crates stay on 0.61. Both splits fail multiple-versions = "deny" on routine updates. Skip the older major of each, version-scoped, so any further duplicate still fails. Also correct the getrandom@0.2 comment, which named only the 0.4 split.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: cachekit-io/cachekit-core/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe dependency ban skip list retains two exemptions with updated conflict descriptions. It adds exemptions for ChangesDependency ban configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The audit policy allows the specified dependency versions while continuing to deny other duplicates. No identified issue blocks merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This PR changes only the
cargo-denyconfiguration indeny.toml. It does not modify any public APIs, library code or runtime behavior.Summary
It adds two version-scoped entries to
bans.skipso that pending dependency updates (serde, thiserror, cbindgen) passcargo deny check bans.multiple-versions = "deny"stays in effect for every other crate. It also updates the comment on the existinggetrandom@0.2skip.Changes
New skip entries in
deny.toml:syn@2zeroize_deriveserde_derive,thiserror-impl(syn 3)windows-sys@0.52rustix/errnoanstylecrates (0.61)Each entry names only the older major version, the same way the existing
getrandom@0.2andwinnow@0.7skips do. A third version ofsynorwindows-sysstill fails the check, as does a duplicate of any other crate.Updated comment on
getrandom@0.2:reasonfield is unchanged.Impact
mainlockfile, cargo-deny reportsunnecessary-skipforsynandunmatched-skipforwindows-sys. This is expected until the updates land. Later, the same warnings will show when a skip has gone stale and can be removed.