Conversation
vitest.integration.config.ts set testTimeout: 60000 but left hookTimeout at vitest's 10s default. The Redis and Memcached Testcontainers suites pass 60000 to beforeAll explicitly, but their afterAll (client quit + container stop) takes no timeout argument, so teardown ran on the 10s default and could fail the lane after every test in it had passed. The report reads "Hook timed out in 10000ms" with a code frame pointing at the beforeAll closing line, which misdirects to setup. Setting hookTimeout at the config level gives teardown the same budget as setup and covers any future Testcontainers suite without per-hook arguments.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. WalkthroughThe Vitest integration test configuration now sets ChangesIntegration test configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The integration test hook timeout is increased to 60 seconds, with no remaining evidence of a merge-blocking issue. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![kodus-27b[bot]](https://avatars.githubusercontent.com/u/223823690?s=60&v=4){kind=small}
1 participant
Description
This PR adds a
hookTimeoutconfiguration of 60 seconds to the Vitest integration test configuration.What Changed
In
packages/cachekit/vitest.integration.config.ts, ahookTimeout: 60000setting was added alongside the existingtestTimeout: 60000.Why
By default, Vitest applies the
testTimeoutvalue only to individual test cases, but setup/teardown hooks (beforeAll,afterAll,beforeEach,afterEach) use a separate, shorter defaulthookTimeout. As the PR title indicates, the goal is to give theafterAllteardown the same 60-second timeout as the tests themselves.Impact
This prevents integration test hooks—particularly teardown logic that may involve slow operations like cleaning up external resources or cache connections—from timing out prematurely and causing flaky or failing test runs.