fix: reset task-progress popup after docking - #68
Draft
John-Ryan21337 wants to merge 1 commit into
Draft
John-Ryan21337 wants to merge 1 commit into
John-Ryan21337 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docking the task list hides
ComposerTaskProgresswithout unmounting its React state. A pinned popup can therefore return already open, causing the first click or Enter press after undocking to close it. This clears the transient open state and hover/press mode while the session rail is visible. Fixes #67.The regression fails on unmodified dev
99fbaec89da429924171c89d66a8f3455e42d9b0: after a keyboard open and dock/undock cycle,aria-expandedremains true. With this fix the control returns closed, and the first Enter press opens the task list. The stored rail preference, layout, and provider state are unchanged.This is a separate repair for the inherited lifecycle failure exposed by the Ubuntu browser job on #66. The feature proposal in #66 does not change this component or its existing docking test.
Validation:
yarn fmt,yarn lint,yarn typecheck,yarn test --concurrency=2(4,037 passed; five existing skips), the full browser suite (307 passed), andyarn build:desktop --force. An independent review passed without additional changes.Before, the first Enter press after returning to the composer closes the popup:
After, the same first Enter press opens it:
Short interaction recording.