fix(desktop): bind IPC authority to the configured renderer - #75
Open
John-Ryan21337 wants to merge 1 commit into
Open
John-Ryan21337 wants to merge 1 commit into
John-Ryan21337 wants to merge 1 commit into
Conversation
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop IPC currently trusts a registered renderer's identity without binding it to the renderer URL. This change binds each trusted webContents to its configured loopback origin or production file and prevents main-frame navigation outside that scope. Child-frame navigation remains available, while child-frame IPC stays rejected.
Sender-aware handlers receive the validated event, and opt-in strict decoding rejects unknown payload fields before running capability-bearing handlers. This is a small prerequisite for isolated browser tabs; it does not add the browser runtime or UI.
Validation: full format, lint, and10-workspace typecheck passed; full tests passed10/10; focused IPC/window11/11; forced desktop build3/3 after tests. An initial parallel full test run hit6 unchanged server reactor timeouts; the exact fixture82/82 and serialized full rerun passed without test changes. Independent security review repaired and tested the main/subframe redirect distinction.