fix: bind artifact audit to the packaged update target - #84
Draft
John-Ryan21337 wants to merge 1 commit into
Draft
John-Ryan21337 wants to merge 1 commit into
John-Ryan21337 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79.
Desktop builds already select their GitHub update repository from the build configuration, including
GITHUB_REPOSITORYin fork CI. The packaged-artifact audit currently accepts onlycafeai/cafe-code, so a valid fork installer can fail its runtime self-test.Bind the resolved publish target into the packaged manifest and validate update metadata against that exact target. Missing legacy metadata keeps the official Cafe fallback. Runtime environment variables cannot change the packaged identity. The parser rejects duplicate keys, nested values, endpoint overrides, invalid identities, and oversized metadata; it accepts the scalar quoting and cache/channel fields produced by the current builder.
This changes only the manifest producer, audit consumer, and their tests. Provider versions, bootstrap, installer targets, signing, and release selection are unchanged.
Validation:
dev, then passes with this fix.yarn fmt,yarn lint, and fullyarn typecheckpass. Fullyarn test --concurrency=2 --summarizepasses all 10 workspaces: 4,041 tests passed and five existing skips.yarn build:desktop --forcepasses all three tasks. Fresh server, renderer, and desktop artifacts are present, and the desktop bundle contains the packaged update-target validation.The resource tests use synthetic package files. This lane does not claim a new signed installer or a physical install on every platform.