Skip to content

补 (:open …) 理由以通过 Calcit 0.39 / Add (:open …) reasons for Calcit 0.39 - #107

Merged
tiye merged 1 commit into
mainfrom
claude/open-reasons-039
Nov 9, 2026
Merged

tiye merged 1 commit into
mainfrom
claude/open-reasons-039

Conversation

@tiye

@tiye tiye commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Requested by Jon · project thread

升级到 Calcit 0.39.0 后,这个库无需改代码即可通过检查:0.39.0 起,项目 Fn schema 里用到 AnyEnum / AnyFn / AnyStruct 而没有写 (:open …) 理由时报 E_OPEN_WITHOUT_REASON(calcit-lang/calcit#2635)。本 PR 只给这些已审阅的签名补上理由,类型和运行行为都不变;(:open …) 从 Calcit 0.37.0 起就能解析,当前锁定的版本可以直接合并。

改动

  • docs-workflow.main/dispatch-view!:接收视图层派发的匿名操作,用 try-decode-map-as 解码成 docs-workflow.schema/Op,标 (:open :decode)。

测试

只改 schema 选项,交给本仓库 CI;在 Calcit main(0.39.0 待发布)上用 calcit query schema 确认新 schema 能正常加载。


English

Calcit 0.39.0 rejects AnyEnum / AnyFn / AnyStruct in a project Fn schema without an (:open …) reason (calcit-lang/calcit#2635). This adds the reason to the reviewed open signatures listed above. Types and runtime behaviour are unchanged, and (:open …) parses since Calcit 0.37.0.


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the view-dispatch interface’s input handling. No changes to the visible behavior of the application were reported.

Calcit 0.39.0 rejects AnyEnum/AnyFn/AnyStruct in a Fn schema without an
(:open …) reason (E_OPEN_WITHOUT_REASON, calcit#2635).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019bPdumFbDJPBLciCYrQ6MN
@tiye tiye self-assigned this Nov 9, 2026
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The dispatch-view! function declaration now marks its AnyEnum input as open and decodable. The implementation is unchanged.

Changes

dispatch-view! schema

Layer / File(s) Summary
Update the function declaration
calcit.cirru
The dispatch-view! schema adds :open :decode to its existing AnyEnum input.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: claude

Merge Risk: Minimal · up to 081f6

The schema annotation preserves existing behavior while accommodating Calcit 0.39 validation. No merge-blocking issue is identified; merge after normal checks pass.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: adding (:open …) reasons for Calcit 0.39. The raw summary describes a signature change that adds (:open :decode) to dispatch-view! in calcit.cirru. The title covers the mai…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: adding (:open …) reasons for Calcit 0.39. The raw summary describes a signature change that adds (:open :decode) to dispatch-view! in calcit.cirru. The title covers the main change, which is the open-reason addition. It does not name the specific function, so it is a partial match in detail only.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7ab0a073-0415-421b-9550-7fb1da2e335c
Commits

Reviewing files that changed from the base of the PR and between ab66c4c and 081f633.

Files selected for processing: 1

  • calcit.cirru

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tiye
tiye merged commit f05d5a0 into main Nov 9, 2026
1 check passed
@tiye
tiye deleted the claude/open-reasons-039 branch November 9, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants