You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Existing saved guide data continues to load when provided in the legacy format.
The default guide state is now used only when no data is provided. Other unsupported data is reported as an error instead of being treated as default state.
No actionable comments were generated in the recent review.
Walkthrough
Navigation state maps now use coordinate keys and a recursive StateValue type. comp-container handles present and absent :data values differently, and the updater decodes :states and :navigate with the typed map.
Changes
Navigation state typing
Layer / File(s)
Summary
State value contract calcit.cirru
Adds the recursive StateValue union and uses it for the Store :states and Op :states map values.
Typed state handling calcit.cirru
comp-container accepts State values or decodes legacy maps, raises an error for other present values, and uses the default guide state only when :data is absent. The updater decodes :states and :navigate using the typed map.
calcit-lang/docs-workflow#97: Declares the Store :states map type and updater decode types that this change replaces.
Suggested reviewers: claude
Merge Risk: Minimal · up to 8fcf6
The change tightens the navigation state types without changing the documented interactions. No actionable merge-blocking risk was found. Downstream consumers with custom state trees will need to follow the stricter key and value types.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "用递归 union 收紧 Docs Workflow 状态树" (Tighten the Docs Workflow state tree with a recursive union) matches the main change in the changeset. The raw summary shows a new recursive StateValue unio…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "用递归 union 收紧 Docs Workflow 状态树" (Tighten the Docs Workflow state tree with a recursive union) matches the main change in the changeset. The raw summary shows a new recursive StateValue union, typed Store :states and Op :states maps, and a comp-container that reads :data as docs-workflow.schema/State. The PR objectives describe the same goal. The title is specific and concise, and it names the primary change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 90bf0d52-21c4-449f-9492-c92828b53ad8
Commits
Reviewing files that changed from the base of the PR and between c94f969 and 8fcf6ea.
Files selected for processing: 1
calcit.cirru
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用者需要注意
文档导航和快捷跳转弹窗继续使用现有交互。使用 Docs Workflow 的项目升级后,自定义状态树的键须符合 CoordKey,值须属于 StateValue。若自定义 updater,需接收具名导航操作和受检的弹窗状态 Map。
改动与风险
Summary by CodeRabbit