You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Store data normalization now accepts recognized StoreData values or maps. Maps with a :states field use its contents; when the field is missing, states default to an empty map. Other input types now produce an empty store. Plain struct maps named StoreData are no longer converted.
No actionable comments were generated in the recent review.
Walkthrough
The change updates I/O and state feature declarations, changes how normalize-store-data handles inputs, narrows a workflow coverage assertion, and updates Calcit and @calcit/procs references to version 0.42.1.
Changes
Calcit declarations and version update
Layer / File(s)
Summary
I/O and state feature declarations calcit.cirru
Several declarations add :io and :state features. Existing :js-ffi declarations remain where indicated.
Store-data normalization and coverage calcit.cirru, .github/workflows/upload.yaml
normalize-store-data accepts nominal StoreData values or maps with map-valued :states, defaulting missing :states to {}. Other inputs return store. The workflow assertion now matches only gen-code.schema/read-open-field-or.
Calcit version alignment deps.cirru, package.json, README.md
The configured Calcit and @calcit/procs versions and the README references change from 0.42.0 to 0.42.1.
Issue 41 concerns StoreData restoration after a format and parse round trip. This change modifies normalize-store-data handling for nominal StoreData values and maps, but the supplied summary does not establish that the reported case is fixed.
Possibly related PRs
calcit-lang/gen-code#45: This PR changes read-open-field-or, which the current changes also reference in its signature and the coverage assertion.
calcit-lang/gen-code#42: This PR changed the normalize-store-data restoration path that the current changes modify.
Merge Risk: Minimal · up to 3776a
This upgrades Calcit to 0.42.1 and adjusts store-data normalization and feature declarations. No actionable merge-blocking risk was found in the supplied evidence.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title says the PR upgrades Gen Code to Calcit 0.42.1 and tightens the save-restore signature. The raw summary confirms the version bump to 0.42.1 in README.md, calcit.cirru, deps.cirru, and packag…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title says the PR upgrades Gen Code to Calcit 0.42.1 and tightens the save-restore signature. The raw summary confirms the version bump to 0.42.1 in README.md, calcit.cirru, deps.cirru, and package.json. It also shows the restore path change, where normalize-store-data now accepts only nominal StoreData structs or maps, and the workflow coverage check now targets read-open-field-or. The title covers the main changes, though it does not mention the removed coverage exception or the StoreData normalization change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: a9c01241-fde3-41f1-9ca7-36d5ce14968d
Commits
Reviewing files that changed from the base of the PR and between e4cc7a5 and 3776a0a.
Files ignored due to path filters: 1
yarn.lock is excluded by !**/yarn.lock, !**/*.lock
Files selected for processing: 5
.github/workflows/upload.yaml
README.md
calcit.cirru
deps.cirru
package.json
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用者影响
升级后重新生成前端 JS,既有草稿和存档仍按原形状恢复。
改动与验证
存档读取入口以泛型保留输入类型,经旧 Map 或 Struct 的运行时分支恢复为 StoreData,移除一项覆盖率例外。
本地不可变安装、完整 strict、原 JS 回归及前端构建通过。
Summary by CodeRabbit
StoreDatavalues or maps. Maps with a:statesfield use its contents; when the field is missing, states default to an empty map. Other input types now produce an empty store. Plain struct maps namedStoreDataare no longer converted.