Skip to content

保留 Gen Code 操作解码的输入类型 - #65

Merged
tiye merged 1 commit into
mainfrom
refine/gen-code-operation-input
Nov 13, 2026
Merged

tiye merged 1 commit into
mainfrom
refine/gen-code-operation-input

Conversation

@tiye

@tiye tiye commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

使用者需要注意

插件事件、存档恢复和流式输出照常使用,调用方无需调整。

改动与风险

  • 操作解码入口使用泛型输入,移除一处 AnyEnum。保留原载荷校验与 Option GenCodeOp 返回合同,未知或无效事件仍返回 None。
  • 正式 Calcit 0.42.1 的 247 个定义、strict、原弱类型门禁、7 项测试、流式输出与派发回归及 Vite 构建均通过。

Summary by CodeRabbit

  • Refactor
    • Updated how generated-code operations accept inputs. No user-visible behavior changes are expected.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The declaration of decode-gen-code-op now uses generic Input instead of AnyEnum with :open :decode. The function implementation is unchanged.

Changes

Decode operation input

Layer / File(s) Summary
Update decode operation input declaration
calcit.cirru
decode-gen-code-op now declares generic Input instead of AnyEnum with :open :decode. Its implementation is unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Merge Risk: Minimal · up to 3bdde

This change narrows a type declaration and leaves decoding behavior as it was. No concrete risk remains that blocks merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "保留 Gen Code 操作解码的输入类型" (roughly: retain the input type of Gen Code operation decoding) matches the main change. The raw summary says decode-gen-code-op now takes a generic Input argumen…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "保留 Gen Code 操作解码的输入类型" (roughly: retain the input type of Gen Code operation decoding) matches the main change. The raw summary says decode-gen-code-op now takes a generic Input argument instead of AnyEnum with the :open :decode annotation, with the implementation unchanged. The PR objectives describe the same goal of using a generic input at the decoding entry point and removing one use of AnyEnum. The title is specific and accurate for the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5fca6cb1-b449-477e-9430-f971273a7860
Commits

Reviewing files that changed from the base of the PR and between 0ab7d04 and 3bdde35.

Files selected for processing: 1

  • calcit.cirru

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@tiye
tiye merged commit a6663a4 into main Nov 13, 2026
1 check passed
@tiye
tiye deleted the refine/gen-code-operation-input branch November 13, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant