Redesign task create/edit modals with desktop sidebar layout and mobile bottom sheet#2118
Open
christenbc wants to merge 1 commit into
Open
Redesign task create/edit modals with desktop sidebar layout and mobile bottom sheet#2118christenbc wants to merge 1 commit into
christenbc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR overhauls the task create and edit modal experience on both desktop and mobile. The goal is to make writing and editing tasks feel faster, clearer, and more platform-appropriate—without changing task data model or save behavior.
What users get
Desktop
Mobile
Create flow
Why this approach
The previous modal mixed legacy split-layout rules with newer mobile patterns. That caused real bugs (duplicate fields, clipped titles, wrong section order, footer wrapping, sidebar clipping). Rather than patching CSS on top of conflicting layouts, this PR:
shouldUseEditSidebarLayout()and related guards intaskModalLayout.ts.taskModalSidebar,taskModalSheetGestures,taskModalChipListEditor,taskModalPropertyMenus— so modal classes stay orchestration-only.task-modal-sheet.cssfor sheet behavior; incremental BEM updates intask-modal.cssfor desktop sidebar and grouped sections.Scope & non-goals
Testing
Review notes
This is a large diff (~7.4k lines) but mostly mechanical extraction + styling. Suggested review order:
taskModalLayout.ts— layout mode decisions (highest risk)taskModalSidebar.ts+taskModalOrganizationFields.ts— desktop/mobile field orderingtaskModalSheetGestures.ts+taskModalSheetKeyboard.ts— mobile sheet behaviorstyles/task-modal-sheet.css— sheet-specific rules isolated from desktopdocs/releases/unreleased.md— user-facing changelogHappy to split follow-up PRs if preferred (e.g. sheet gestures vs. desktop sidebar), but I kept it together because many fixes only make sense once both layouts land.
Screenshots / recordings