Skip to content

fix: record real completion date on materialized occurrences #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raphaelfaouakhiri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: record real completion date on materialized occurrences #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/services/TaskService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,10 @@ export class TaskService {
}

private getCompletionDateForTask(task: TaskInfo): string {
return task.occurrence_date || getCurrentDateString();
// Record the real completion date, matching non-recurring task behavior.
// Which occurrence was fulfilled is tracked separately on the parent's
// complete_instances (see buildMaterializedOccurrenceCompletePlan). #2125
return getCurrentDateString();
}

/**
Expand Down
5 changes: 4 additions & 1 deletion tests/unit/services/task-occurrence-materialization.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,9 +437,12 @@ describe("TaskService materialized occurrences", () => {

await taskService.updateProperty(occurrence, "status", "done");

// completedDate records when the user actually completed the occurrence
// (the mocked "today", 2025-01-01), while the parent's complete_instances
// keeps tracking WHICH occurrence was fulfilled (the occurrence date).
expect(frontmatterByPath.get(occurrence.path)).toMatchObject({
status: "done",
completedDate: "2026-06-01",
completedDate: "2025-01-01",
});
expect(frontmatterByPath.get(parent.path)).toMatchObject({
complete_instances: ["2026-06-01"],
Expand Down